Require time core extensions in all environments #39059
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These have been required in the generated test environment config since 1c7207a, but the generated development config also uses them (albeit inside a conditional), and the generated production config contains a comment which uses them. More generally, we shouldn't require core extensions in one environment and not others, since applications with `config.active_support.bare` enabled could rely on them implicitly and exhibit inconsistent behaviour across environments.
|
Good catch. |
thomasleese
added a commit
to alphagov/service-manual-frontend
that referenced
this pull request
Feb 26, 2021
This is part of upgrading to Rails 6.1 and matches the change upstream: rails/rails#39059
edwardkerry
pushed a commit
to alphagov/service-manual-frontend
that referenced
this pull request
Jun 23, 2021
This is part of upgrading to Rails 6.1 and matches the change upstream: rails/rails#39059
|
I know I'm late to this, but is there a reason this require isn't moved to (I've moved this require to config/application in one rails app after another, particularly after custom environments get created and forget to add the require. So I finally git-blamed the line to get here looking for more context 😄 ) |
|
Locality. This happens to be a dependency of these particular files because they use the extension. It is a local thing, perhaps your Even if it happens to be used by the three of them, that is not enough justification to take the |
|
That's fair, thanks @fxn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been required in the generated test environment config since 1c7207a, but the generated development config also uses them (albeit inside a conditional):
rails/railties/lib/rails/generators/rails/app/templates/config/environments/development.rb.tt
Line 25 in a5469f0
...and the generated production config contains a comment which uses them:
rails/railties/lib/rails/generators/rails/app/templates/config/environments/production.rb.tt
Line 127 in a5469f0
More generally, we shouldn't require core extensions in one environment and not others, since applications with
config.active_support.bareenabled could rely on them implicitly and exhibit inconsistent behaviour across environments.Somewhat incidentally closes #37391.